This repository was archived by the owner on Jan 23, 2026. It is now read-only.
Fix CLI install script race condition causing flaky CI tests#389
Merged
Fix CLI install script race condition causing flaky CI tests#389
Conversation
- Remove separate curl --head check that created race condition window - Use single curl -L --fail request with retry logic (3 attempts) - Add 2-second delay between retries with progress feedback - Maintains all existing functionality while eliminating timing issues Fixes flaky CI test failures caused by checksum verification mismatches when CDN/cache serves different versions between HEAD and GET requests. Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jhaynie
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CLI Install Script Race Condition
Problem
The CLI CI tests have been flaky for the past week, failing intermittently with checksum verification errors like:
Root Cause
The install script's
download_release()function had a race condition caused by two separate HTTP requests:curl --headto check if the file existscurl -Lto actually download the fileBetween these requests, CDN caching or load balancing could serve different versions of the same file, causing the downloaded binary to have a different checksum than expected.
Solution
This PR eliminates the race condition by:
curl -L --failrequest - downloads directly with proper error handlingTesting
Changes
install.shdownload_release()functionThis is the safest possible fix as it completely eliminates the race condition window while maintaining backward compatibility and adding resilience against transient network issues.
Link to Devin run: https://app.devin.ai/sessions/d5d8ceb46c4b4f81adb6d94857c5bca2
Requested by: jhaynie@agentuity.com